Skip to content

[v18] use new join service for host and bot joins #60293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: branch/v18
Choose a base branch
from
Open

[v18] use new join service for host and bot joins #60293

wants to merge 8 commits into from

Conversation

@nklaassen
Copy link
Contributor

@nklaassen nklaassen commented Oct 15, 2025 •
edited
Loading

@nklaassen nklaassen added do-not-merge no-changelog Indicates that a PR does not require a changelog entry labels Oct 15, 2025
@nklaassen nklaassen mentioned this pull request Oct 15, 2025
Closed
@nklaassen nklaassen force-pushed the nklaassen/v18/join-boundkeypair-tests branch from 6e5c981 to 061ac8b Compare October 16, 2025 19:05
@nklaassen nklaassen force-pushed the nklaassen/v18/new-join-service-used branch from 3f3458c to 5f3125d Compare October 16, 2025 19:05
@nklaassen nklaassen changed the base branch from nklaassen/v18/join-boundkeypair-tests to branch/v18 October 16, 2025 19:06
@nklaassen nklaassen mentioned this pull request Oct 17, 2025
Merged
@nklaassen nklaassen force-pushed the nklaassen/v18/new-join-service-used branch from f68b6e9 to fb8248f Compare October 20, 2025 17:42
@nklaassen nklaassen mentioned this pull request Oct 23, 2025
Merged
@nklaassen
Copy link
Contributor Author

nklaassen commented Oct 28, 2025 •
edited
Loading

#60673 and #60706 contain bug fixes that should be merged along with this now included in this PR

@timothyb89 timothyb89 mentioned this pull request Oct 29, 2025
Open
@nklaassen nklaassen force-pushed the nklaassen/v18/new-join-service-used branch from 58d62f7 to 102e603 Compare October 29, 2025 15:56
@nklaassen nklaassen added do-not-merge and removed do-not-merge no-changelog Indicates that a PR does not require a changelog entry labels Nov 3, 2025
@nklaassen nklaassen mentioned this pull request Nov 4, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boxofrad boxofrad boxofrad approved these changes

@timothyb89 timothyb89 timothyb89 approved these changes

@tigrato tigrato tigrato approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

Assignees

No one assigned

Labels

do-not-merge machine-id size/md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nklaassen @boxofrad @timothyb89 @tigrato @rosstimothy @fspmarshall