Remove remaining uses of github.com/coreos/go-oidc/v3 with github.com/zitadel/oidc/v3
#54939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
reviewed
May 20, 2025
Collaborator
Do you need to update |
Contributor
|
go mod graph | rg "github.com/coreos/go-oidc"
github.com/sigstore/cosign/[email protected] github.com/coreos/go-oidc/[email protected]
github.com/sigstore/[email protected] github.com/coreos/go-oidc/[email protected]
github.com/sigstore/[email protected] github.com/coreos/go-oidc/[email protected]
k8s.io/[email protected] github.com/coreos/[email protected]+incompatible |
rosstimothy
reviewed
May 20, 2025
go.mod
Outdated
| github.com/ucarion/urlpath v0.0.0-20200424170820-7ccc79b76bbb | ||
| github.com/vulcand/predicate v1.2.0 // replaced | ||
| github.com/yusufpapurcu/wmi v1.2.4 | ||
| github.com/zeebo/assert v1.3.0 |
Contributor
There was a problem hiding this comment.
Oooof this is likely an accidental import from gopls and should be replaced with testify/assert
Joerger
added
the
no-changelog
rosstimothy
reviewed
May 22, 2025
…ovider timeout is used for all providers.
Joerger
force-pushed
the
joerger/remove-coreos-go-oidc
branch
from
1a04744 to
7eae3ce
Compare
rosstimothy
approved these changes
May 22, 2025
strideynet
approved these changes
May 23, 2025
public-teleport-github-review-bot
bot
removed request for
hugoShaka,
marcoandredinis and
tigrato
This was referenced May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
github.com/zitadel/oidc/v3, adapted from Noah's additions for azure devops. The only intended functional change here is that the 15s provider timeout is used for all providers, rather than just the 2 newest additions.tctl sso configureuses zitadel's Discover function instead of the old coreos provider function..golangci.ymlto only allowgithub.com/zitadel/oidc/v3go mod tidyNote: For some reason, I can't get rid of
github.com/coreos/go-oidcandgithub.com/coreos/go-oidc/v3from thego.sum, despite them being completely unused: