Skip Authorized Party check for GCP joining #55236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
added
test-plan-problem
Collaborator
|
Please file an issue with |
Joerger
removed
the
test-plan-problem
strideynet
approved these changes
May 29, 2025
Contributor
strideynet
left a comment
strideynet
left a comment
There was a problem hiding this comment.
Fixed gcp joining in my development cluster. Thank you!
rosstimothy
approved these changes
May 29, 2025
public-teleport-github-review-bot
bot
removed request for
doggydogworld and
ravicious
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #54939, we migrated from
github.com/coreos/go-oidc/v3togithub.com/zitadel/oidc/v3. The zitadel library includes a strict check for the oidc Authorized Party claim by default, which is not compatible with GCP. According to the OIDC spec, this should in fact be an optional check.While we wait for the upstream PR to make this check optional, this PR fixes the GCP regression by skipping the check utilizing zitadel's exported function.
Closes #55238