Implement e2e testing setup for the Web UI #54094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
the
no-changelog
gzdunek
reviewed
Apr 18, 2025
gzdunek
reviewed
Apr 24, 2025
hugoShaka
reviewed
Apr 24, 2025
rudream
force-pushed
the
yassine/e2e-3
branch
2 times, most recently
from
3a30b54 to
34fb975
Compare
gzdunek
reviewed
May 8, 2025
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
The last three comments from the previous batch are marked as resolved, but it doesn't look like they've been addressed. Do you plan to address them?
rudream
force-pushed
the
yassine/e2e-3
branch
2 times, most recently
from
7acbff5 to
d234075
Compare
gzdunek
reviewed
May 14, 2025
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
Left a few final comments.
gzdunek
approved these changes
May 15, 2025
avatus
approved these changes
May 15, 2025
hugoShaka
approved these changes
May 15, 2025
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
LGTM with minor nits, I only looked at the go bits
rudream
force-pushed
the
yassine/e2e-3
branch
2 times, most recently
from
e61f786 to
2f63e2f
Compare
rosstimothy
reviewed
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces the setup for end-to-end testing in the Web UI using Playwright against a real running Teleport instance and a test for the signup flow.