Update print_environment to show featureLevel and defaultDevice #4130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
print_environment
test to print all properties with a blocklist, rather than print only specific properties, and to print the properties of the default device (i.e. requestDevice with no descriptor).Aside: there are still two other places using
isCompatibilityMode
:getDefaultLimitsForAdapter()
This should probably be updated to understand both
isCompatibilityMode
andfeatureLevel
,but we also need to consider how it can work if we remove
adapter.featureLevel
(Compat: remove GPUAdapter.featureLevel gpuweb#5037, cc @greggman)webgpu:api,operation,adapter,requestDevice:always_returns_device:*
Should just be updated to understand both.
Anyway, result from this PR:
Issue: None
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.