Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code that uses adapter.isCompatibilityMode #4131

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Jan 8, 2025

We could probably remove compatibilityMode already? But I'm not sure. We can do that in a separate step.

Issue: None


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

And update all comments about removing `compatibilityMode: boolean`.
Copy link
Collaborator

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

src/webgpu/capability_info.ts Outdated Show resolved Hide resolved
src/webgpu/api/operation/adapter/requestDevice.spec.ts Outdated Show resolved Hide resolved
@kainino0x kainino0x enabled auto-merge (squash) January 8, 2025 23:31
@kainino0x kainino0x merged commit 2a7c7f9 into gpuweb:main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants