Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: adjust for 0 vert/frag storage buffers/textures #4088

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

greggman
Copy link
Contributor

Compat allows supporting 0 storage buffers and storage textures in fragment shaders. Update some tests for this situation.

@greggman greggman requested a review from kainino0x December 11, 2024 06:37
@greggman greggman force-pushed the zero-frag-vert-storage-texture-buffers branch from 8c5e1d1 to b6f05cf Compare December 11, 2024 06:38
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Compat does allows supporting 0 storage buffers and storage textures
in fragment shaders. Update some test for this situation.
@greggman greggman force-pushed the zero-frag-vert-storage-texture-buffers branch from 2d5f3cb to c427874 Compare December 12, 2024 07:42
@greggman greggman enabled auto-merge (squash) December 12, 2024 07:42
@greggman greggman merged commit 64eb522 into gpuweb:main Dec 12, 2024
1 check passed
@greggman greggman deleted the zero-frag-vert-storage-texture-buffers branch December 12, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants