Skip to content

Commit

Permalink
fix previous change
Browse files Browse the repository at this point in the history
  • Loading branch information
greggman committed Dec 12, 2024
1 parent 11c9521 commit 2d5f3cb
Showing 1 changed file with 16 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -167,21 +167,23 @@ g.test('createPipeline,at_over')
`can not test ${testValue} bindings in same group because maxBindingsPerBindGroup = ${device.limits.maxBindingsPerBindGroup}`
);

t.skipIf(
(bindingCombination === 'fragment' ||
bindingCombination === 'vertexAndFragmentWithPossibleVertexStageOverflow' ||
bindingCombination === 'vertexAndFragmentWithPossibleFragmentStageOverflow') &&
testValue > (device.limits.maxStorageBuffersInFragmentStage ?? actualLimit),
`can not test ${testValue} bindings as it is more than maxStorageBuffersInFragmentStage(${device.limits.maxStorageBuffersInFragmentStage})`
);
if (t.isCompatibility) {
t.skipIf(
(bindingCombination === 'fragment' ||
bindingCombination === 'vertexAndFragmentWithPossibleVertexStageOverflow' ||
bindingCombination === 'vertexAndFragmentWithPossibleFragmentStageOverflow') &&
testValue > device.limits.maxStorageBuffersInFragmentStage!,
`can not test ${testValue} bindings as it is more than maxStorageBuffersInFragmentStage(${device.limits.maxStorageBuffersInFragmentStage})`
);

t.skipIf(
(bindingCombination === 'vertex' ||
bindingCombination === 'vertexAndFragmentWithPossibleVertexStageOverflow' ||
bindingCombination === 'vertexAndFragmentWithPossibleFragmentStageOverflow') &&
testValue > (device.limits.maxStorageBuffersInVertexStage ?? actualLimit),
`can not test ${testValue} bindings as it is more than maxStorageBuffersInVertexStage(${device.limits.maxStorageBuffersInVertexStage})`
);
t.skipIf(
(bindingCombination === 'vertex' ||
bindingCombination === 'vertexAndFragmentWithPossibleVertexStageOverflow' ||
bindingCombination === 'vertexAndFragmentWithPossibleFragmentStageOverflow') &&
testValue > device.limits.maxStorageBuffersInVertexStage!,
`can not test ${testValue} bindings as it is more than maxStorageBuffersInVertexStage(${device.limits.maxStorageBuffersInVertexStage})`
);
}

const code = getPerStageWGSLForBindingCombination(
bindingCombination,
Expand Down

0 comments on commit 2d5f3cb

Please sign in to comment.