Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for GPURequestAdapterOptions featureLevel #4077

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented Dec 5, 2024

Following up on gpuweb/gpuweb#4897, this PR adds tests for GPURequestAdapterOptions featureLevel.

image
Tests pass in Chromium patched with https://chromium-review.googlesource.com/c/chromium/src/+/6067690

image
Tests don't pass yet* in Safari Tech Preview

image Tests don't pass yet* in Firefox Nightly

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.) They pass in Chromium patched with https://chromium-review.googlesource.com/c/chromium/src/+/6067690
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x enabled auto-merge (squash) December 5, 2024 20:37
@kainino0x kainino0x merged commit 9223c26 into main Dec 5, 2024
1 check passed
@kainino0x kainino0x deleted the featureLevel branch December 5, 2024 20:41
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 5, 2024
Spec PR: gpuweb/gpuweb#4897
CTS PR: gpuweb/cts#4077

Bug: 366151404
Change-Id: I451a5e66f85468cb433b9f20edf7c09644ac8cd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6067690
Reviewed-by: Kai Ninomiya <[email protected]>
Commit-Queue: Kai Ninomiya <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1392500}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants