-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set featureLevel: "compatibility"
when compatibility=1 is enabled
#4081
Conversation
It's not immediately apparent that we will need to be able to run the CTS under customizable featureLevel values. It would be much simpler and avoid a lot of migration work if the CTS just keeps The thing that we need to do is have CTS request adapters using |
@kainino0x This makes this PR much simpler ;) |
featureLevel: "compatibility"
when compatibility=1 is enabled
I think this should be changed so it doesn't request Instead of
It should be
wdyt? |
|
The problem is it makes the CTS never test that you get core if you don't request any feature level |
I believe this will be tested once |
Note that I've added #4077 already |
As suggested in https://g-issues.chromium.org/issues/366151404#comment9, this PR adds a featureLevel CTS option.
Note that I'm not 100% sure I cover all changes required for the CTS.
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.