Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for subgroupShuffle variants #4061

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

alan-baker
Copy link
Contributor

  • Refactor some duplicated code into subgroup_util.ts
    • typed input generation
    • framebuffer parameter generation
  • Add tests for subgroup shuffle variants
    • All variants: subgroupShuffle, subgroupShuffleUp, subgroupShuffleDown, subgroupShuffleXor
    • Fragment tests
    • Data type tests
    • specific variant tests
    • randomized compute tests
    • predicated compute tests

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot and I may have missed things.
LGTM.

* Refactor some duplicated code into subgroup_util.ts
  * typed input generation
  * framebuffer parameter generation
* Add tests for subgroup shuffle variants
  * All variants: subgroupShuffle, subgroupShuffleUp,
    subgroupShuffleDown, subgroupShuffleXor
  * Fragment tests
  * Data type tests
  * specific variant tests
  * randomized compute tests
  * predicated compute tests
@alan-baker alan-baker enabled auto-merge (squash) November 29, 2024 14:20
@alan-baker alan-baker merged commit a0713ec into gpuweb:main Nov 29, 2024
1 check passed
@alan-baker alan-baker deleted the subgroup-shuffle branch November 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants