subgroupBallot tests in fragment shaders #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-baker
changed the title
alan-baker
force-pushed
the
subgroup-ballot-fragment
branch
from
9a5f143 to
e1dd2f6
Compare
dneto0
approved these changes
Nov 29, 2024
| @@ -344,4 +348,315 @@ fn main(@builtin(subgroup_size) subgroupSize : u32, | |||
| await runTest(t, wgsl, testcase.filter, testcase.expect, false); | |||
| }); | |||
|
|
|||
| g.test('fragment').unimplemented(); | |||
| // Filters should always skip the last row and column. | |||
There was a problem hiding this comment.
nit: recommend saying why: To avoid potential interference from helper invocations.
There was a problem hiding this comment.
and now I see it's commented on below too. Nice.
|
|
||
| const mapping = new Map<number, bigint>(); | ||
|
|
||
| // Iteration skips last row and column to avoid helper invocations because it is not |
|
|
||
| // Iteration skips last row and column to avoid helper invocations because it is not | ||
| // guaranteed whether or not they participate in the subgroup operation. | ||
| for (let row = 0; row < height - 1; row++) { |
There was a problem hiding this comment.
this is all very clean. Nice.
* Tests subgroupBallot in fragment shaders
alan-baker
force-pushed
the
subgroup-ballot-fragment
branch
from
e1dd2f6 to
ce2b8d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.