Compat: skip 'cube-array' validation tests. #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
approved these changes
Nov 5, 2024
| @@ -718,6 +718,10 @@ g.test('resource_compatibility') | |||
| !t.hasLanguageFeature('readonly_and_readwrite_storage_textures'), | |||
| 'Storage textures require language feature' | |||
| ); | |||
| t.skipIf(t.isCompatibility && wgslResource.texture !== undefined && | |||
There was a problem hiding this comment.
this can be
t.skipIfTextureViewDimensionNotSupported(wgslResource.texture?.viewDimension);Same below
SenorBlanco
force-pushed
the
skip-cube-array-validation-compat
branch
from
c0c2949 to
12e277b
Compare
Cube arrays are unsupported in Compatibility mode.
SenorBlanco
force-pushed
the
skip-cube-array-validation-compat
branch
from
12e277b to
b7271ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cube arrays are unsupported in Compatibility mode.