Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gpuweb/cts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c0c2949c104feea0df3692c4f4250fa0896008f8
Choose a base ref
..
head repository: gpuweb/cts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 12e277bf636b489a1037d43fab613fe2ceb69ce6
Choose a head ref
Showing with 7 additions and 4 deletions.
  1. +4 −2 src/webgpu/api/validation/compute_pipeline.spec.ts
  2. +3 −2 src/webgpu/api/validation/render_pipeline/resource_compatibility.spec.ts
6 changes: 4 additions & 2 deletions src/webgpu/api/validation/compute_pipeline.spec.ts
View file
Original file line number Diff line number Diff line change
@@ -718,8 +718,10 @@ g.test('resource_compatibility')
!t.hasLanguageFeature('readonly_and_readwrite_storage_textures'),
'Storage textures require language feature'
);
t.skipIf(t.isCompatibility && wgslResource.texture !== undefined &&
wgslResource.texture.viewDimension === 'cube-array',
t.skipIf(
t.isCompatibility &&
wgslResource.texture !== undefined &&
wgslResource.texture.viewDimension === 'cube-array',
'Compatibility mode does not support cube arrays'
);

5 changes: 3 additions & 2 deletions src/webgpu/api/validation/render_pipeline/resource_compatibility.spec.ts
View file
Original file line number Diff line number Diff line change
@@ -56,8 +56,9 @@ g.test('resource_compatibility')
'Storage buffers and textures cannot be used in vertex shaders'
);
t.skipIf(
t.isCompatibility && wgslResource.texture !== undefined &&
wgslResource.texture.viewDimension == 'cube-array',
t.isCompatibility &&
wgslResource.texture !== undefined &&
wgslResource.texture.viewDimension === 'cube-array',
'Compatibility mode does not support cube arrays'
);
const emptyVS = `