Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable depth24plus, depth24plus-stencil8, depth32float-stencil8 in texture builtins #4012

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

greggman
Copy link
Contributor


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman changed the title Enable depth24plus, depth24plus-stencil8, depth32float-stencil8 in texture builins Enable depth24plus, depth24plus-stencil8, depth32float-stencil8 in texture builtins Oct 23, 2024
@greggman greggman requested a review from kainino0x October 23, 2024 07:44
@greggman greggman requested review from shrekshao and removed request for kainino0x October 28, 2024 20:27
@greggman greggman enabled auto-merge (squash) October 29, 2024 16:51
@greggman greggman merged commit 32f8ad2 into gpuweb:main Oct 29, 2024
1 check passed
@greggman greggman deleted the tb-d24-d32-stencil branch October 29, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants