Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makeRandomDepthComparisonTexelGenerator #4048

Merged

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Nov 19, 2024

This bug broke textureXXCompare tests with unencodable depth formats which were added recently.

#4012

This bug broke all textureXXCompare tests with unencodable depth formats.
@greggman greggman requested a review from kainino0x November 19, 2024 20:53
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greggman greggman merged commit 990c238 into gpuweb:main Nov 19, 2024
1 check passed
@greggman greggman deleted the fix-makeRandomDepthComparisonTexelGenerator branch November 19, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants