Correct expectation for shift equal to bit width #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a shader/pipeline-creation error if the number of bits to shift is greater than *or equal to* the bit width of the value to shift.
zoddicus
approved these changes
Jul 18, 2024
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Jul 18, 2024
This validation already existed when the whole shift expression could be const evaluated, but it also applies when only the rhs is const, and the lhs is a concrete type. This change moves that validation into the resolver to catch more cases. Other cases like divide by zero should also be covered by Validator::BinaryExpression in future. Related CTS fixes in: gpuweb/cts#3868 Bug: 352768986 Change-Id: I958949dfab2e43670fa358dd11563c5bba40ce20 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/199075 Reviewed-by: James Price <[email protected]> Commit-Queue: Natalie Chouinard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a shader/pipeline-creation error if the number of bits to shift is greater than or equal to the bit width of the value to shift. This change corrects the expectations for the equals case, and adds a function reference to the pipeline subcase so it isn't stripped out.
These tests will pass in Dawn following: https://dawn-review.googlesource.com/c/dawn/+/199075
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.