Type texture

[shrekshao]

First try adding to WGSL validation tests: texel_formats, storage_texture_types

Failing cases in Chrome:
- storage_texture_types: format without readWriteStorage usage didn't get rejected with 'read-write' access.

• bgra8unorm

For other texture types (e.g. sampled textures, multisampled textures etc.) I think they need api side binding creation to test the format validation. Do we want to include that as part of these shader validation tests?

---

Requirements for PR author:

• All missing test coverage is tracked with "TODO" or .unimplemented().
• New helpers are /** documented */ and new helper files are found in helper_index.txt.
• Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
• Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

• Tests are properly located in the test tree.
• Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
• Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
• Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

[shrekshao]

Obsolete comment: ~~Yeah seems to be an implementation bug. But I'm not 100% sure given there'screateShaderModule test in the bgra8unorm_stoarge test that passes, with and without bgra8unorm_storage feature~~

…

On Tue, Mar 12, 2024, 11:18 Ben Clayton ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/webgpu/shader/validation/types/textures.spec.ts <#3472 (comment)>: > +`; + t.expectCompileResult(false, wgsl); + }); + +g.test('storage_texture_types') + .desc( + `Test that for texture_storage_xx<format, access> +- format must be an enumerant for one of the texel formats for storage textures +- access must be an enumerant for one of the access modes +` + ) + .params(u => + u + .combine('access', ['read', 'write', 'read_write'] as const) + .combine('format', kAllTextureFormats) + // bgra8unorm-storage feature is tested at webgpu,api,validation,texture,bgra8unorm_storage Seems to fail for all access (when bgra8unorm-storage is not requried) Sorry, please can you elaborate a little? You believe you've found an implementation bug? — Reply to this email directly, view it on GitHub <#3472 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGMNLCOUPAE6BAATLGYOG3YX5BGHAVCNFSM6AAAAABENPRLM2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMZRHE3DGNRUHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jrprice]

LGTM