-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assignment of AInt to u32 in the expression generator #3379
Merged
amaiorano
merged 1 commit into
gpuweb:main
from
amaiorano:fix-abstract-to-u32-assignment
Feb 8, 2024
Merged
Fix assignment of AInt to u32 in the expression generator #3379
amaiorano
merged 1 commit into
gpuweb:main
from
amaiorano:fix-abstract-to-u32-assignment
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaiorano
requested review from
zoddicus and
ben-clayton
and removed request for
zoddicus
February 8, 2024 20:09
ben-clayton
reviewed
Feb 8, 2024
Apply the same fix that was made for AFloat to AInt when emitting the value assignment WGSL. Otherwise, if globalTestConfig.unrollConstEvalLoops is true, as it is on Windows, then we emit invalid WGSL because we index an array of AInts with a runtime index, forcing concretization, which results in an assignment of i32 to u32. The fix is to do as was done with AFloat: we emit direct assignments of the literal values into the output array. Also made sure we don't emit the array of values in this case, as it's unused.
amaiorano
force-pushed
the
fix-abstract-to-u32-assignment
branch
from
February 8, 2024 20:25
23e2707
to
ef33557
Compare
ben-clayton
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm still not used to GitHub. I had replied "Thanks!" to your suggetions, but those got lost when I resolved them... |
ben-clayton
added a commit
to ben-clayton/cts
that referenced
this pull request
Mar 12, 2024
Extends the fix of gpuweb#3379 to cover composite types.
8 tasks
ben-clayton
added a commit
to ben-clayton/cts
that referenced
this pull request
Mar 12, 2024
Extends the fix of gpuweb#3379 to cover composite types.
ben-clayton
added a commit
to ben-clayton/cts
that referenced
this pull request
Mar 12, 2024
Extends the fix of gpuweb#3379 to cover composite types.
ben-clayton
added a commit
that referenced
this pull request
Mar 12, 2024
Extends the fix of #3379 to cover composite types.
ben-clayton
added a commit
to ben-clayton/cts
that referenced
this pull request
Mar 18, 2024
Extends the fix of gpuweb#3379 to cover composite types.
ben-clayton
added a commit
to ben-clayton/cts
that referenced
this pull request
Mar 18, 2024
Extends the fix of gpuweb#3379 to cover composite types.
ben-clayton
added a commit
to ben-clayton/cts
that referenced
this pull request
Mar 19, 2024
Extends the fix of gpuweb#3379 to cover composite types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the same fix that was made for AFloat to AInt when emitting the value assignment WGSL. Otherwise, if
globalTestConfig.unrollConstEvalLoops is true, as it is on Windows, then we emit invalid WGSL because we index an array of AInts with a runtime index, forcing concretization, which results in an assignment of i32 to u32. The fix is to do as was done with AFloat: we emit direct assignments of the literal values into the output array. Also made sure we don't emit the array of values in this case, as it's unused.
This fixes
'webgpu:shader,execution,expression,unary,ai_assignment:*'
tests that were failing on Windows.Issue: #1644
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.