Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shader/execution: Fix composite abstract runtime indexing #3484

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

ben-clayton
Copy link
Contributor

@ben-clayton ben-clayton commented Mar 12, 2024

Extends the fix of #3379 to cover composite types.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@ben-clayton ben-clayton force-pushed the fix-abstract-unroll branch from 2507197 to f2d928f Compare March 12, 2024 16:51
@ben-clayton ben-clayton requested a review from amaiorano March 12, 2024 16:51
Extends the fix of gpuweb#3379 to cover composite types.
@ben-clayton ben-clayton force-pushed the fix-abstract-unroll branch from f2d928f to 22d7fce Compare March 12, 2024 20:22
@ben-clayton ben-clayton enabled auto-merge (rebase) March 12, 2024 20:24
@ben-clayton ben-clayton merged commit 53158b8 into gpuweb:main Mar 12, 2024
1 check passed
@ben-clayton ben-clayton deleted the fix-abstract-unroll branch March 12, 2024 20:35
ben-clayton added a commit to ben-clayton/cts that referenced this pull request Apr 15, 2024
Extends the fix of gpuweb#3484 to cover **nested** composite types.
ben-clayton added a commit to ben-clayton/cts that referenced this pull request Apr 15, 2024
Extends the fix of gpuweb#3484 to cover **nested** composite types.
ben-clayton added a commit that referenced this pull request Apr 15, 2024
)

Extends the fix of #3484 to cover **nested** composite types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants