Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Revert changes to round execution tests #3090

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

zoddicus
Copy link
Contributor

These were landed on the wrong branch, and are causing tests to fail to build, because some of the code that they depend on is implemented in a PR that hasn't landed yet.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

These were landed on the wrong branch, and are causing tests to fail
to build, because some of the code that they depend on is implemented
in a PR that hasn't landed yet.
@zoddicus zoddicus added the wgsl label Oct 24, 2023
@zoddicus zoddicus self-assigned this Oct 24, 2023
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@github-actions
Copy link

Previews, as seen when this build job started (41ef8b0):
Run tests | View tsdoc

@zoddicus zoddicus merged commit b929ebb into gpuweb:main Oct 24, 2023
2 checks passed
@zoddicus zoddicus deleted the revertMislandedRound branch October 24, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants