Skip to content

Commit b929ebb

Browse files
authored
wgsl: Revert changes to round execution tests (#3090)
These were landed on the wrong branch, and are causing tests to fail to build, because some of the code that they depend on is implemented in a PR that hasn't landed yet.
1 parent 8e7a995 commit b929ebb

File tree

1 file changed

+6
-21
lines changed

1 file changed

+6
-21
lines changed

src/webgpu/shader/execution/expression/call/builtin/round.spec.ts

+6-21
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ Component-wise when T is a vector.
1212

1313
import { makeTestGroup } from '../../../../../../common/framework/test_group.js';
1414
import { GPUTest } from '../../../../../gpu_test.js';
15-
import { TypeF32, TypeF16, TypeAbstractFloat } from '../../../../../util/conversion.js';
15+
import { TypeF32, TypeF16 } from '../../../../../util/conversion.js';
1616
import { FP } from '../../../../../util/floating_point.js';
17-
import { fullF32Range, fullF16Range, fullF64Range } from '../../../../../util/math.js';
17+
import { fullF32Range, fullF16Range } from '../../../../../util/math.js';
1818
import { makeCaseCache } from '../../case_cache.js';
19-
import { allInputSources, onlyConstInputSource, run } from '../../expression.js';
19+
import { allInputSources, run } from '../../expression.js';
2020

21-
import { abstractBuiltin, builtin } from './builtin.js';
21+
import { builtin } from './builtin.js';
2222

2323
export const g = makeTestGroup(GPUTest);
2424

@@ -43,30 +43,15 @@ export const d = makeCaseCache('round', {
4343
FP.f16.roundInterval
4444
);
4545
},
46-
abstract: () => {
47-
return FP.abstract.generateScalarToIntervalCases(
48-
[
49-
0x8000_0000_0000_0000, // https://github.com/gpuweb/cts/issues/2766
50-
...fullF64Range(),
51-
],
52-
'unfiltered',
53-
FP.abstract.roundInterval
54-
);
55-
},
5646
});
5747

5848
g.test('abstract_float')
5949
.specURL('https://www.w3.org/TR/WGSL/#float-builtin-functions')
6050
.desc(`abstract float tests`)
6151
.params(u =>
62-
u
63-
.combine('inputSource', onlyConstInputSource)
64-
.combine('vectorize', [undefined, 2, 3, 4] as const)
52+
u.combine('inputSource', allInputSources).combine('vectorize', [undefined, 2, 3, 4] as const)
6553
)
66-
.fn(async t => {
67-
const cases = await d.get('abstract');
68-
await run(t, abstractBuiltin('round'), [TypeAbstractFloat], TypeAbstractFloat, t.params, cases);
69-
});
54+
.unimplemented();
7055

7156
g.test('f32')
7257
.specURL('https://www.w3.org/TR/WGSL/#float-builtin-functions')

0 commit comments

Comments
 (0)