Fix a bad slice operation in image_copy stencil tests #3083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that in the
checkStencilTextureContent()
method of theimage_copy
tests anArrayBuffer.slice()
is being used that was passing arguments as if they were(offset, length)
, when in fact they must be(start, end)
. This was causing any tests with a buffer offset other than 0 to pass even where there was an error because the arrays that were being compared were zero length.After correcting this issue I also found that a separate buffer offset needed to be passed to the
expectGPUBufferValuesEqual()
method to account for the offset of the row being tested. This was preventing anything other than the first row from being compared properly, though that didn't cause an error due to the aforementionedslice()
issue.Once these two fixes are in place the test can now properly check all subcases. Confirmed passing on Chrome.
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.