Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a minor issue introduced in previous stencil test fix #3086

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

toji
Copy link
Member

@toji toji commented Oct 24, 2023

I flubbed one line in #3083, not realizing that the row stride needed to be computed differently for the source data and readback data. Previous code worked fine for the offsets_and_sizes_copy_depth_stencil tests, but failed for the rowsPerImage_and_bytesPerRow_depth_stencil tests. This fix allows both to work as expected.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@toji toji requested a review from kainino0x October 24, 2023 17:49
@github-actions
Copy link

Previews, as seen when this build job started (4c24894):
Run tests | View tsdoc

@kainino0x kainino0x merged commit 7991cc7 into main Oct 24, 2023
2 checks passed
@kainino0x kainino0x deleted the stencil-fix-2 branch October 24, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants