address comments

gpuweb · Dec 12, 2024 · 11c9521 · 11c9521
1 parent b6f05cf
commit 11c9521
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/webgpu/api/validation/capability_checks/limits/maxStorageBuffersPerShaderStage.spec.ts b/src/webgpu/api/validation/capability_checks/limits/maxStorageBuffersPerShaderStage.spec.ts
@@ -171,15 +171,15 @@ g.test('createPipeline,at_over')
           (bindingCombination === 'fragment' ||
             bindingCombination === 'vertexAndFragmentWithPossibleVertexStageOverflow' ||
             bindingCombination === 'vertexAndFragmentWithPossibleFragmentStageOverflow') &&
-            testValue > device.limits.maxStorageBuffersInFragmentStage,
+            testValue > (device.limits.maxStorageBuffersInFragmentStage ?? actualLimit),
           `can not test ${testValue} bindings as it is more than maxStorageBuffersInFragmentStage(${device.limits.maxStorageBuffersInFragmentStage})`
         );
 
         t.skipIf(
           (bindingCombination === 'vertex' ||
             bindingCombination === 'vertexAndFragmentWithPossibleVertexStageOverflow' ||
             bindingCombination === 'vertexAndFragmentWithPossibleFragmentStageOverflow') &&
-            testValue > device.limits.maxStorageBuffersInVertexStage,
+            testValue > (device.limits.maxStorageBuffersInVertexStage ?? actualLimit),
           `can not test ${testValue} bindings as it is more than maxStorageBuffersInVertexStage(${device.limits.maxStorageBuffersInVertexStage})`
         );
 

diff --git a/src/webgpu/gpu_test.ts b/src/webgpu/gpu_test.ts
@@ -71,10 +71,10 @@ import { reifyExtent3D, reifyOrigin3D } from './util/unions.js';
 declare global {
   // MAINTENANCE_TODO: remove once added to @webgpu/types
   interface GPUSupportedLimits {
-    readonly maxStorageBuffersInFragmentStage: number;
-    readonly maxStorageTexturesInFragmentStage: number;
-    readonly maxStorageBuffersInVertexStage: number;
-    readonly maxStorageTexturesInVertexStage: number;
+    readonly maxStorageBuffersInFragmentStage?: number;
+    readonly maxStorageTexturesInFragmentStage?: number;
+    readonly maxStorageBuffersInVertexStage?: number;
+    readonly maxStorageTexturesInVertexStage?: number;
   }
 }