Skip to content

fix: pluralise time units in created time output #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityashekhawat1999 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pluralise time units in created time output #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pkg/utils/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ import (
"unicode"
)

func pluralise(value int, unit string) string {
if value == 1 {
return fmt.Sprintf("%d %s ago", value, unit)
}
return fmt.Sprintf("%d %ss ago", value, unit)
}

func FormatCreatedTime(timestamp string) (string, error) {
t, err := time.Parse(time.RFC3339Nano, timestamp)
if err != nil {
Expand All @@ -38,11 +45,11 @@ func FormatCreatedTime(timestamp string) (string, error) {
days := int(duration.Hours() / 24)

if minutes < 60 {
return fmt.Sprintf("%d minute ago", minutes), nil
return pluralise(minutes, "minute"), nil
} else if hours < 24 {
return fmt.Sprintf("%d hour ago", hours), nil
return pluralise(hours, "hour"), nil
} else {
return fmt.Sprintf("%d day ago", days), nil
return pluralise(days, "day"), nil
}
}

Expand Down