Skip to content

Comments

fix: pluralise time units in created time output#691

Open
adityashekhawat1999 wants to merge 1 commit intogoharbor:mainfrom
adityashekhawat1999:fix-time-pluralisation
Open

fix: pluralise time units in created time output#691
adityashekhawat1999 wants to merge 1 commit intogoharbor:mainfrom
adityashekhawat1999:fix-time-pluralisation

Conversation

@adityashekhawat1999
Copy link

@adityashekhawat1999 adityashekhawat1999 commented Feb 7, 2026

solves #709
Overview
This PR improves the UX of by fixing the pluralisation of time units in the Created Time output (for example, displaying “2 hours ago” instead of “2 hour ago”).

Changes
Before:
before
After:
after

  • Updated time formatting logic to correctly pluralise time units (minute, hour, day) based on their values.
  • Verified the behaviour by building and running the Harbor CLI locally and checking the updated output.

Note
This is a small UX improvement so i addressed it directly in a PR rather than opening a separate issue first.

Signed-off-by: Aditya Pratap Singh Shekhawat <adityashekhawat@Adityas-MacBook-Air.local>
Copy link
Collaborator

@qcserestipy qcserestipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! However, our project policy requires that every PR is linked to a pre-existing, approved issue. Could you please open an issue describing the pluralisation bug first and reference it in this PR? Without a linked issue, we'll need to close this PR. Thanks for understanding!

@adityashekhawat1999
Copy link
Author

Thanks for the contribution! However, our project policy requires that every PR is linked to a pre-existing, approved issue. Could you please open an issue describing the pluralisation bug first and reference it in this PR? Without a linked issue, we'll need to close this PR. Thanks for understanding!

Thanks i have opened the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants