Support @export_file, @export_dir etc. for Array<GString> and PackedStringArray
#1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
feature
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1166 |
Bromeon
force-pushed
the
feature/export-file-arrays
branch
2 times, most recently
from
ad55478 to
2f761d4
Compare
Bromeon
force-pushed
the
feature/export-file-arrays
branch
from
2f761d4 to
1abc4ac
Compare
…ng> + PackedStringArray Also cause error if another field type is used.
Also adjust error when #[export(file)] is used on arrays in older versions
Bromeon
force-pushed
the
feature/export-file-arrays
branch
from
1abc4ac to
0065fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the
#[export(file)],#[export(file = "*.png")]attributes and all their variants on two new types beside the existingGString:Array<GString>PackedStringArrayAlso introduces very basic error handling for the case where
#[export(...)]attributes are used on a type that doesn't support them. This is currently done via panic and can be improved in future versions, but would be out of scope for this PR.Closes #772.