-
-
Notifications
You must be signed in to change notification settings - Fork 232
Support @export_storage
attribute
#1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your contribution! 👍 I would probably merge the other changes to exports #1166 first, which might cause small merge conflicts, but I expect it wouldn't be difficult to resolve. Maybe you can already rebase onto that branch 🙂 Regarding failing CI, you can run tests locally, see Dev tools and testing. |
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1183 |
Awesome! @Bromeon It turns out that this is more involved than I had initially expected. |
b3b5201
to
284935c
Compare
I was having issues running To save space, I have my I'm able to run them now. I'll address the issues I found 👍 Original Post@Bromeon ./check.sh itest 130 ↵
Checks to run: itest
Found 'godot' executable with version 4.4.1.stable.arch_linux
> cargo build -p itest --no-default-features
Compiling godot-codegen v0.2.4 (./gdext/godot-codegen)
Compiling godot-macros v0.2.4 (./gdext/godot-macros)
Compiling godot-ffi v0.2.4 (./gdext/godot-ffi)
Compiling godot-core v0.2.4 (./gdext/godot-core)
Compiling itest v0.0.0 (./gdext/itest/rust)
Compiling godot v0.2.4 (./gdext/godot)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.31s
> godot --path itest/godot --headless -- \[\]
ERROR: Condition "!FileAccess::exists(path)" is true. Returning: ERR_FILE_NOT_FOUND
at: open_dynamic_library (drivers/unix/os_unix.cpp:893)
ERROR: GDExtension dynamic library not found: 'res://itest.gdextension'.
at: open_library (core/extension/gdextension.cpp:701)
ERROR: Error loading extension: 'res://itest.gdextension'.
at: load_extensions (core/extension/gdextension_manager.cpp:291)
Godot Engine v4.4.1.stable.arch_linux - https://godotengine.org
SCRIPT ERROR: Parse Error: Identifier "IntegrationTests" not declared in the current scope.
at: GDScript::reload (res://TestRunner.gd:41)
ERROR: Failed to load script "res://TestRunner.gd" with error "Parse error".
at: load (modules/gdscript/gdscript.cpp:3022) |
19985b7
to
5cf7cb6
Compare
Tests are working with Godot 4.4. I'll try and see if I can downgrade my Godot version to test with older versions and make sure everything is good to go 👍 |
5cf7cb6
to
8e051d9
Compare
Final fixes in place. Tests are passing for Godot Also tested in my current project, and |
8e051d9
to
4dd6e37
Compare
Rebased from |
4dd6e37
to
819207d
Compare
I was doing an unnecessary No more changes incoming 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
819207d
to
3177514
Compare
@export_storage
attribute
Thanks a lot for your contribution, and congrats to the first merged PR! 😊 |
Partially completes #1128
See GDScript: Add
@export_storage
annotation godotengine/godot#82122 added in Godot 4.3Adds the ability to annotate a field with
@export_storage
: