Skip to content

fix: update repo and issue urls #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpschen wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Open

fix: update repo and issue urls #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config-raw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,7 @@
{
"key": "language",
"default_value": "\u003cunset\u003e",
"comment": "The language of the user interface. Must be an ISO 639-1 language code followed by an ISO 3166-1 alpha-2 country code. Check https://kolaente.dev/vikunja/vikunja/frontend/src/branch/main/src/i18n/lang for a list of possible languages. Will default to the browser language the user uses when signing up."
"comment": "The language of the user interface. Must be an ISO 639-1 language code followed by an ISO 3166-1 alpha-2 country code. Check https://code.vikunja.io/frontend/src/i18n/lang for a list of possible languages. Will default to the browser language the user uses when signing up."
},
{
"key": "timezone",
Expand Down
5 changes: 4 additions & 1 deletion desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
"version": "v0.1.0",
"description": "Vikunja's frontend as a standalone desktop application.",
"main": "main.js",
"repository": "https://code.vikunja.io/desktop",
"repository": "https://code.vikunja.io/vikunja/tree/main/desktop",
Copy link
Member

@kolaente kolaente Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could stay at code.vikunja.io/desktop

Copy link
Contributor Author

@dpschen dpschen Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Before I update this: I think I was confused by the fact that https://code.vikunja.io/frontend/tree/main/src/i18n/lang redirects to the old frontend repo. Is that intended?

Copy link
Contributor Author

@dpschen dpschen Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more precise:

Since

https://code.vikunja.io/frontend

redirects to

https://github.com/go-vikunja/vikunja/tree/main/frontend

I would expect

https://code.vikunja.io/frontend/tree/main/src/i18n/lang

to redirect to

https://github.com/go-vikunja/vikunja/tree/main/frontend/src/i18n/lang

Instead we end up at

https://github.com/go-vikunja/frontend/tree/main/src/i18n/lang

Copy link
Member

@kolaente kolaente Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah well I guess that's a bug in the redirection

https://github.com/go-vikunja/go-package-redirect/blob/ae38a9d60e73f18abc837af6edb19c232c422098/src/index.ts#L52

Yeah seems like it only matches the exact suffix and not the thing after it.

Copy link
Contributor Author

@dpschen dpschen Apr 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a pr for the redirects go-vikunja/go-package-redirect#1. I'll adjust this pr, when the redirect is fixed.

"bugs": {
"url": "https://code.vikunja.io/vikunja/issues"
},
"license": "GPL-3.0-or-later",
"packageManager": "[email protected]",
"author": {
Expand Down
4 changes: 2 additions & 2 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"license": "AGPL-3.0-or-later",
"repository": {
"type": "git",
"url": "https://kolaente.dev/vikunja/vikunja"
"url": "https://code.vikunja.io/vikunja/tree/main/frontend"
Copy link
Member

@kolaente kolaente Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be code.vikunja.io/frontend

},
"bugs": {
"url": "https://kolaente.dev/vikunja/vikunja/issues"
"url": "https://code.vikunja.io/vikunja/issues"
},
"homepage": "https://vikunja.io/",
"funding": "https://opencollective.com/vikunja",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/styles/custom-properties/colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// Core Bulma color variables
// Added (from bulma-css-variables/css/bulma.css) to fix issues with undefined variables
// This section should be removed once bulma/sass scoping issues are fixed
// see https://kolaente.dev/vikunja/frontend/issues/1064
// see https://code.vikunja.io/vikunja/issues/502
// Variables overriden in Vikunja specific rules below are commented out
//--scheme-main: white;
--scheme-main-bis: #fafafa;
Expand Down