Skip to content

Conversation

@dpschen
Copy link
Contributor

@dpschen dpschen commented Apr 10, 2025

Further tasks

Screenshot 2025-04-10 at 10 22 29

@kolaente
Copy link
Member

I've added redirects for the frontend and desktop to code.vikunja.io. We should use these urls everywhere, to make sure they can be changed easily if needed.

@dpschen dpschen force-pushed the fix/repo-and-issue-urls branch from 9602cd3 to a5498c1 Compare April 11, 2025 12:54
"description": "Vikunja's frontend as a standalone desktop application.",
"main": "main.js",
"repository": "https://code.vikunja.io/desktop",
"repository": "https://code.vikunja.io/vikunja/tree/main/desktop",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could stay at code.vikunja.io/desktop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Before I update this: I think I was confused by the fact that https://code.vikunja.io/frontend/tree/main/src/i18n/lang redirects to the old frontend repo. Is that intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more precise:

Since

https://code.vikunja.io/frontend

redirects to

https://github.com/go-vikunja/vikunja/tree/main/frontend

I would expect

https://code.vikunja.io/frontend/tree/main/src/i18n/lang

to redirect to

https://github.com/go-vikunja/vikunja/tree/main/frontend/src/i18n/lang

Instead we end up at

https://github.com/go-vikunja/frontend/tree/main/src/i18n/lang

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah well I guess that's a bug in the redirection

https://github.com/go-vikunja/go-package-redirect/blob/ae38a9d60e73f18abc837af6edb19c232c422098/src/index.ts#L52

Yeah seems like it only matches the exact suffix and not the thing after it.

Copy link
Contributor Author

@dpschen dpschen Apr 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a pr for the redirects go-vikunja/go-package-redirect#1. I'll adjust this pr, when the redirect is fixed.

"repository": {
"type": "git",
"url": "https://kolaente.dev/vikunja/vikunja"
"url": "https://code.vikunja.io/vikunja/tree/main/frontend"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be code.vikunja.io/frontend

@kolaente kolaente enabled auto-merge (squash) April 11, 2025 13:57
@kolaente kolaente disabled auto-merge April 11, 2025 13:57
dpschen added a commit to dpschen/vikunja-redirect that referenced this pull request Apr 13, 2025
dpschen added a commit to dpschen/vikunja-redirect that referenced this pull request Apr 13, 2025
@dpschen dpschen force-pushed the fix/repo-and-issue-urls branch from a5498c1 to e918968 Compare April 13, 2025 11:13
@dpschen dpschen force-pushed the fix/repo-and-issue-urls branch from e918968 to 0d89d08 Compare April 13, 2025 11:14
@dpschen
Copy link
Contributor Author

dpschen commented Jun 1, 2025

@kolaente also found https://hub.docker.com/r/vikunja/golang-build (the golang-build or is broken)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants