-
-
Notifications
You must be signed in to change notification settings - Fork 254
fix: update repo and issue urls #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I've added redirects for the frontend and desktop to |
9602cd3 to
a5498c1
Compare
| "description": "Vikunja's frontend as a standalone desktop application.", | ||
| "main": "main.js", | ||
| "repository": "https://code.vikunja.io/desktop", | ||
| "repository": "https://code.vikunja.io/vikunja/tree/main/desktop", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could stay at code.vikunja.io/desktop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Before I update this: I think I was confused by the fact that https://code.vikunja.io/frontend/tree/main/src/i18n/lang redirects to the old frontend repo. Is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more precise:
Since
https://code.vikunja.io/frontend
redirects to
https://github.com/go-vikunja/vikunja/tree/main/frontend
I would expect
https://code.vikunja.io/frontend/tree/main/src/i18n/lang
to redirect to
https://github.com/go-vikunja/vikunja/tree/main/frontend/src/i18n/lang
Instead we end up at
https://github.com/go-vikunja/frontend/tree/main/src/i18n/lang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah well I guess that's a bug in the redirection
Yeah seems like it only matches the exact suffix and not the thing after it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a pr for the redirects go-vikunja/go-package-redirect#1. I'll adjust this pr, when the redirect is fixed.
| "repository": { | ||
| "type": "git", | ||
| "url": "https://kolaente.dev/vikunja/vikunja" | ||
| "url": "https://code.vikunja.io/vikunja/tree/main/frontend" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be code.vikunja.io/frontend
a5498c1 to
e918968
Compare
e918968 to
0d89d08
Compare
|
@kolaente also found https://hub.docker.com/r/vikunja/golang-build (the golang-build or is broken) |
Further tasks
rontend