macOS: add "command finished" notifications#10934
Merged
mitchellh merged 3 commits intoghostty-org:mainfrom Feb 26, 2026
Merged
macOS: add "command finished" notifications#10934mitchellh merged 3 commits intoghostty-org:mainfrom
mitchellh merged 3 commits intoghostty-org:mainfrom
Conversation
JosephMart
commented
Feb 21, 2026
JosephMart
commented
Feb 21, 2026
Comment on lines
+1418
to
+1425
| if actions.contains(.bell) { | ||
| NotificationCenter.default.post( | ||
| name: .ghosttyBellDidRing, | ||
| object: surfaceView | ||
| ) | ||
| } | ||
|
|
||
| if actions.contains(.notify) { |
Contributor
Author
There was a problem hiding this comment.
Anything to consider if notify and bell are enabled with bell-features = system,attention? Can hear both sounds playing.
Example config
bell-features = system,attention
notify-on-command-finish = always
notify-on-command-finish-action = notify, bell
notify-on-command-finish-after = 2s
JosephMart
commented
Feb 21, 2026
JosephMart
commented
Feb 21, 2026
simlf
approved these changes
Feb 23, 2026
mitchellh
force-pushed
the
josephmart/macos-notify-cmd-finish
branch
from
9644d5c to
f4ddddc
Compare
mitchellh
approved these changes
Feb 26, 2026
Contributor
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
Thanks, this looks good. I made some stylistic changes and fixed the notification not showing up with focus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10840
Implement command finished notifications for MacOS. Building on the work of #8992
AI Tools Used