Skip to content

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Aug 4, 2025

Changes to the SentryOptions+HybridSdk

This PR also addresses the changes of getsentry/sentry-cocoa#5698 where SentryOptions+HybridSDKs.h morphed into SentryOptionsInternal.h.

Sample events

cursor[bot]

This comment was marked as outdated.

#import <Sentry/Sentry.h>
#import <MetricKit/MetricKit.h>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to add #import <MetricKit/MetricKit.h>. Otherwise it will break in Sentry-Switft.h with

@interface SentryMXManager : NSObject <MXMetricManagerSubscriber> -- No type or protocol named 'MXMetricManagerSubscriber'

@bitsandfoxes bitsandfoxes requested review from vaind and a team August 5, 2025 11:16
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to assume this is properly tested manually and/or in smoke tests?

Base automatically changed from chore/create-xcframework-in-ci to main August 6, 2025 13:20
@bitsandfoxes
Copy link
Contributor Author

Is it safe to assume this is properly tested manually and/or in smoke tests?

Of course!

@bitsandfoxes bitsandfoxes merged commit 0130165 into main Aug 11, 2025
160 of 161 checks passed
@bitsandfoxes bitsandfoxes deleted the chore/cocoa-bump-8.54.0 branch August 11, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants