-
-
Notifications
You must be signed in to change notification settings - Fork 56
chore: Bump Cocoa SDK to 8.54.0
#2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y/sentry-unity into chore/cocoa-bump-8.54.0
#import <Sentry/Sentry.h> | ||
#import <MetricKit/MetricKit.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to add #import <MetricKit/MetricKit.h>
. Otherwise it will break in Sentry-Switft.h
with
@interface SentryMXManager : NSObject <MXMetricManagerSubscriber> -- No type or protocol named 'MXMetricManagerSubscriber'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to assume this is properly tested manually and/or in smoke tests?
Of course! |
Changes to the
SentryOptions+HybridSdk
This PR also addresses the changes of getsentry/sentry-cocoa#5698 where
SentryOptions+HybridSDKs.h
morphed intoSentryOptionsInternal.h
.Sample events