chore(deps): update Cocoa SDK to v8.54.0 #2262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bruno-garcia
force-pushed
the
deps/modules/sentry-cocoa.properties/8.54.0
branch
from
09c0878 to
da9dc62
Compare
|
Currently blocked by #2263 |
bitsandfoxes
reviewed
Aug 1, 2025
.github/workflows/build.yml
Outdated
| @@ -91,7 +91,7 @@ jobs: | |||
| run: docker exec unity dotnet build -c Release | |||
|
|
|||
| - name: Install assemblyalias | |||
| run: docker exec unity dotnet tool install --global Alias --version 0.4.3 | |||
| run: docker exec unity dotnet tool install --global Alias --version 0.4.3 --allow-roll-forward | |||
There was a problem hiding this comment.
I had to pull the changes from #2263 in here to make CI happy(-ish).
Comment on lines
+2
to
+3
| #import <MetricKit/MetricKit.h> | ||
| #import <Sentry/Sentry-Swift.h> |
There was a problem hiding this comment.
I'm not sure this is the way to go. I have to add #import <MetricKit/MetricKit.h>. Otherwise it will break in Sentry-Switft.h with
@interface SentryMXManager : NSObject <MXMetricManagerSubscriber> -- No type or protocol named 'MXMetricManagerSubscriber'
| #import <MetricKit/MetricKit.h> | ||
| #import <Sentry/Sentry-Swift.h> | ||
| #import <Sentry/PrivateSentrySDKOnly.h> | ||
| #import <Sentry/SentryOptionsInternal.h> |
There was a problem hiding this comment.
This comes from getsentry/sentry-cocoa#5698
scripts/setup-cocoa-sdk.ps1
Outdated
There was a problem hiding this comment.
I've extracted this from the .targets.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Superseded by #2265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2260 by creating
Addresses getsentry/sentry-cocoa#5740
This PR bumps the Cocoa SDK to
8.54.0it does multiple things:"Fixes" Signing Issue
Starting with
8.52.0the Cocoa SDK comes with code signing. This relies on symlinks. This will not work as expected with the way we ship the Unity SDK.Wombo-Combo "Solution": We're now creating an
ios-onlyxcframework out of the downloaded artifact. Doing this makes the resulting bundle a lot smaller and it also gets rid of the code signing."Build" the Cocoa SDK in CI
Since the
ios-onlyxcframework creation relies onxcodebuildthis needs to happen on a macOS runner. I've added the "building" of the Cocoa SDK back tosdk.yml. We wanted to get the ability to build from a submodule anyway and that's half a step in that direction.Changes to the
SentryOptions+HybridSdkThis PR also addresses the changes of getsentry/sentry-cocoa#5698 where
SentryOptions+HybridSDKs.hmorphed intoSentryOptionsInternal.h.Sample events
The auto-bump generated issue description.
Open at your own peril.
Bumps modules/sentry-cocoa.properties from 8.51.0 to 8.54.0.
Auto-generated by a dependency updater.
Changelog
8.54.0
Features
SentrySDK.logger(#5532, #5593, #5639, #5628, #5637, #5643)isiOSAppOnMacandisMacCatalystAppfrom ProcessInfo to the runtime context (#5570)Fixes
beforeSend(#5692)Improvements
integrationsparameter ofSentryOptionsas deprecated rather than printing a warning (#5749)8.53.2
Fixes
bindClient:is called from a different thread (#5523)Improvements
APPLICATION_EXTENSION_API_ONLYrequirement (#5524)8.53.1
Fixes
8.53.0
Features
options.experimental.enableUnhandledCPPExceptionsV2 = true(#5256)Fixes
availableto beiOSinstead ofiOSApplicationExtension(#5361)dyldimage to image cache to fix dyld symbols appearing asunknown(#5418)Improvements
SFSafariViewused bySFSafariViewControllerandASWebAuthenticationSession(#5408)8.53.0-alpha.0
Features
options.experimental.enableUnhandledCPPExceptionsV2 = true(#5256)Fixes
availableto beiOSinstead ofiOSApplicationExtension(#5361)dyldimage to image cache to fix dyld symbols appearing asunknown(#5418)Improvements
SFSafariViewused bySFSafariViewControllerandASWebAuthenticationSession(#5408)8.52.1
Fixes
8.52.0
Features
Improvements
Fixes
8.52.0-beta
Features
Improvements
8.51.1
Fixes
Improvements