-
-
Couldn't load subscription status.
- Fork 276
enh: refactor setExtra and removeExtra to use FFI/JNI
#3303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- refactor `setExtra` and `removeExtra` to use FFI/JNI ([#3303](https://github.com/getsentry/sentry-dart/pull/3303))If none of the above apply, you can opt out of this check by adding |
setExtra and removeExtra to use FFI/JNI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## enh/ffi-jni-set-contexts #3303 +/- ##
============================================================
+ Coverage 87.52% 89.51% +1.98%
============================================================
Files 195 98 -97
Lines 6687 3376 -3311
============================================================
- Hits 5853 3022 -2831
+ Misses 834 354 -480 ☔ View full report in Codecov by Sentry. |
📜 Description
Part of moving away from method channel
💡 Motivation and Context
Partly completes #3204
💚 How did you test it?
Manual, integration test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps