-
-
Notifications
You must be signed in to change notification settings - Fork 371
test(session-replay): Add masking tests for special views #6571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+381
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2025
Added expectations to verify the animation state during redaction, ensuring the position of the masked region is within the expected range during animation. This improves the robustness of the edge case tests for UI redaction.
…se tests Updated the animation duration and expectations in the edge case tests for UI redaction. The assertions now verify that the position of the masked region is approximately at the midpoint of the animation, enhancing the accuracy of the tests.
philipphofmann
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0a40a02 | 1214.75 ms | 1252.63 ms | 37.88 ms |
| 6d40fee | 1217.47 ms | 1245.37 ms | 27.90 ms |
| ec3fc3a | 1212.92 ms | 1245.06 ms | 32.14 ms |
| 73c9712 | 1238.57 ms | 1260.38 ms | 21.80 ms |
| 339539a | 1219.58 ms | 1254.63 ms | 35.05 ms |
| 3279d4e | 1215.76 ms | 1256.45 ms | 40.69 ms |
| df3872a | 1234.37 ms | 1268.72 ms | 34.35 ms |
| 5ae9ff1 | 1222.31 ms | 1250.96 ms | 28.65 ms |
| f5d202b | 1237.90 ms | 1259.49 ms | 21.59 ms |
| 37900c9 | 1236.06 ms | 1262.22 ms | 26.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0a40a02 | 23.75 KiB | 1.01 MiB | 1016.04 KiB |
| 6d40fee | 23.75 KiB | 912.37 KiB | 888.63 KiB |
| ec3fc3a | 23.74 KiB | 1022.75 KiB | 999.01 KiB |
| 73c9712 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
| 339539a | 23.75 KiB | 968.24 KiB | 944.50 KiB |
| 3279d4e | 23.75 KiB | 938.32 KiB | 914.57 KiB |
| df3872a | 23.74 KiB | 1.02 MiB | 1016.77 KiB |
| 5ae9ff1 | 23.74 KiB | 971.82 KiB | 948.08 KiB |
| f5d202b | 23.75 KiB | 904.53 KiB | 880.78 KiB |
| 37900c9 | 23.75 KiB | 958.61 KiB | 934.85 KiB |
|
After feedback from @noahsmartin I need to remove unnecessary snapshots before merging |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Derived from #6292 for stacked merging