Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Oct 28, 2025

Derived from #6292 for stacked merging

@philprime philprime marked this pull request as ready for review October 28, 2025 15:31
Added expectations to verify the animation state during redaction, ensuring the position of the masked region is within the expected range during animation. This improves the robustness of the edge case tests for UI redaction.
…se tests

Updated the animation duration and expectations in the edge case tests for UI redaction. The assertions now verify that the position of the masked region is approximately at the midpoint of the animation, enhancing the accuracy of the tests.
@philprime philprime self-assigned this Oct 28, 2025
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.90 ms 1258.76 ms 28.86 ms
Size 23.75 KiB 1.01 MiB 1016.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0a40a02 1214.75 ms 1252.63 ms 37.88 ms
6d40fee 1217.47 ms 1245.37 ms 27.90 ms
ec3fc3a 1212.92 ms 1245.06 ms 32.14 ms
73c9712 1238.57 ms 1260.38 ms 21.80 ms
339539a 1219.58 ms 1254.63 ms 35.05 ms
3279d4e 1215.76 ms 1256.45 ms 40.69 ms
df3872a 1234.37 ms 1268.72 ms 34.35 ms
5ae9ff1 1222.31 ms 1250.96 ms 28.65 ms
f5d202b 1237.90 ms 1259.49 ms 21.59 ms
37900c9 1236.06 ms 1262.22 ms 26.16 ms

App size

Revision Plain With Sentry Diff
0a40a02 23.75 KiB 1.01 MiB 1016.04 KiB
6d40fee 23.75 KiB 912.37 KiB 888.63 KiB
ec3fc3a 23.74 KiB 1022.75 KiB 999.01 KiB
73c9712 23.75 KiB 908.01 KiB 884.26 KiB
339539a 23.75 KiB 968.24 KiB 944.50 KiB
3279d4e 23.75 KiB 938.32 KiB 914.57 KiB
df3872a 23.74 KiB 1.02 MiB 1016.77 KiB
5ae9ff1 23.74 KiB 971.82 KiB 948.08 KiB
f5d202b 23.75 KiB 904.53 KiB 880.78 KiB
37900c9 23.75 KiB 958.61 KiB 934.85 KiB

Previous results on branch: philprime/fix-masking_split_5

Startup times

Revision Plain With Sentry Diff
9236962 1221.57 ms 1262.51 ms 40.94 ms

App size

Revision Plain With Sentry Diff
9236962 23.75 KiB 1.01 MiB 1016.12 KiB

@philprime
Copy link
Member Author

After feedback from @noahsmartin I need to remove unnecessary snapshots before merging

@philprime philprime marked this pull request as draft October 29, 2025 14:57
@philprime philprime marked this pull request as ready for review November 3, 2025 12:09
@graphite-app graphite-app bot changed the base branch from philprime/fix-masking_split_4 to graphite-base/6571 November 3, 2025 12:27
@philprime philprime changed the base branch from graphite-base/6571 to main November 3, 2025 12:29
@philprime philprime changed the base branch from main to philprime/fix-masking_split_4 November 3, 2025 12:34
Base automatically changed from philprime/fix-masking_split_4 to main November 3, 2025 13:29
@graphite-app
Copy link

graphite-app bot commented Nov 3, 2025

Merge activity

  • Nov 3, 1:29 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Nov 3, 1:29 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@philprime philprime enabled auto-merge (squash) November 3, 2025 14:06
@philprime philprime merged commit 8b966fc into main Nov 3, 2025
194 of 198 checks passed
@philprime philprime deleted the philprime/fix-masking_split_5 branch November 3, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants