Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Oct 28, 2025

Derived from #6292 for stacked merging

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@philprime philprime self-assigned this Oct 28, 2025
Base automatically changed from philprime/fix-masking to main October 28, 2025 16:52
@graphite-app
Copy link

graphite-app bot commented Oct 28, 2025

Merge activity

  • Oct 28, 4:55 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Oct 28, 4:55 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@70eb95e). Learn more about missing BASE report.
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6567   +/-   ##
========================================
  Coverage        ?   85.496%           
========================================
  Files           ?       451           
  Lines           ?     27428           
  Branches        ?     11936           
========================================
  Hits            ?     23450           
  Misses          ?      3935           
  Partials        ?        43           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70eb95e...b70fa5d. Read the comment docs.

@philprime philprime enabled auto-merge (squash) October 29, 2025 08:26
cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.94 ms 1262.42 ms 34.48 ms
Size 23.75 KiB 1.01 MiB 1016.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7bd90de 1233.48 ms 1249.47 ms 15.99 ms
5200f5b 1231.73 ms 1254.35 ms 22.62 ms
96aff5b 1228.40 ms 1263.28 ms 34.88 ms
1a34ddc 1217.79 ms 1242.17 ms 24.38 ms
78af7a9 1225.75 ms 1256.98 ms 31.23 ms
438caec 1230.02 ms 1250.00 ms 19.98 ms
7416ffc 1225.55 ms 1241.80 ms 16.25 ms
e3767a1 1224.20 ms 1257.16 ms 32.96 ms
5258fb8 1207.92 ms 1234.51 ms 26.59 ms
2137530 1223.39 ms 1253.25 ms 29.86 ms

App size

Revision Plain With Sentry Diff
7bd90de 23.75 KiB 933.33 KiB 909.58 KiB
5200f5b 23.75 KiB 933.33 KiB 909.58 KiB
96aff5b 23.75 KiB 1.00 MiB 1002.40 KiB
1a34ddc 23.75 KiB 919.90 KiB 896.15 KiB
78af7a9 23.75 KiB 990.00 KiB 966.26 KiB
438caec 23.74 KiB 913.14 KiB 889.40 KiB
7416ffc 23.75 KiB 913.63 KiB 889.88 KiB
e3767a1 23.75 KiB 913.14 KiB 889.39 KiB
5258fb8 23.75 KiB 874.45 KiB 850.70 KiB
2137530 23.75 KiB 933.33 KiB 909.58 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime merged commit 55eaa36 into main Oct 29, 2025
171 of 173 checks passed
@philprime philprime deleted the philprime/fix-masking_split branch October 29, 2025 09:54
philprime added a commit that referenced this pull request Nov 6, 2025
…in (#6678)

* fix(session-replay): Update rendering method for fast view rendering (#6360)
* fix(session-replay): Extend masking and focus masking on sensitive information (#6292)
* test(session-replay): Add masking tests for common cases (#6567)
* test(session-replay): Add masking tests for React Native views (#6568)
* fix(session-replay): Fix conversion of frame rate to time interval (#6623)
* test(session-replay): Add masking tests for edge cases (#6569)
* test(session-replay): Add masking tests for UIKit views (#6570)
* test(session-replay): Add masking tests for special views (#6571)
* fix(session-replay): Include layer background color when checking if a view is opaque (#6629)
* chore(tests): Remove snapshot testing to reduce repository size (#6631)
* chore: Remove unwanted CHANGELOG entries from cherry-pick
- Remove #5591 (minimum OS version warnings) - not related to session replay
- Remove #6019 (SCNetworkReachability) - not related to session replay
- Remove #6377 (thread event issue) - not related to session replay
- Remove #6381 (frame delay) - duplicate/not related to session replay
- Keep only session replay masking related changes
* docs: Move changelog changes from v8.57.1 to unreleased
* test: Resolve wrong assertions involed due to merge-conflict
* chore: Update sdk_api_V9.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants