Skip to content

test: Improve FileManager PathTooLong assert #6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2025
+10 −3
Merged

test: Improve FileManager PathTooLong assert #6510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57d3baa
test: Improve FileManager PathTooLong assert
philipphofmann Oct 23, 2025
1a770fd
fix testStart_StoresAppState
philipphofmann Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Tests/SentryTests/Helper/SentryFileManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,13 +1082,19 @@ class SentryFileManagerTests: XCTestCase {

let path = fixture.getTooLongPath()
var error: NSError?

// -- Act --
let result = createDirectoryIfNotExists(path, &error)

// -- Assert -
XCTAssertFalse(result)
XCTAssertEqual(error?.domain, SentryErrorDomain)
XCTAssertEqual(error?.code, 108)
XCTAssertEqual(logOutput.loggedMessages.count, 1)

let expectedLogMessage = "Failed to create directory, path is too long: \(path)"
let logMessagesContainsExpected = logOutput.loggedMessages.contains { $0.contains("[Sentry] [fatal]") && $0.contains(expectedLogMessage) }

XCTAssertTrue(logMessagesContainsExpected, "Expected fatal log with message: \(expectedLogMessage)")
}

func testCreateDirectoryIfNotExists_otherError_shouldNotLogError() throws {
Expand Down
5 changes: 3 additions & 2 deletions ...SentryTests/Integrations/WatchdogTerminations/SentryWatchdogTerminationTrackerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ class SentryWatchdogTerminationTrackerTests: NotificationCenterTestCase {
let appState = SentryAppState(releaseName: fixture.options.releaseName ?? "", osVersion: UIDevice.current.systemVersion, vendorId: TestData.someUUID, isDebugging: false, systemBootTimestamp: fixture.sysctl.systemBootTimestamp)

XCTAssertEqual(appState, actual)
XCTAssertEqual(1, fixture.dispatchQueue.dispatchAsyncCalled)

XCTAssertGreaterThanOrEqual(fixture.dispatchQueue.dispatchAsyncCalled, 1, "Expected at least 1 dispatchAsync call for start to ensure we don't run reading the app state on the calling thread.")
}

func testGoToForeground_SetsIsActive() throws {
Expand All @@ -126,7 +127,7 @@ class SentryWatchdogTerminationTrackerTests: NotificationCenterTestCase {
let appState2 = try XCTUnwrap(fixture.fileManager.readAppState())
XCTAssertFalse(appState2.isActive, "Expected appSate to be inactive after going to background.")

XCTAssertGreaterThanOrEqual(fixture.dispatchQueue.dispatchAsyncCalled, 3, "Expected at least 3 dispatchAsync calls (start, foreground, background) to ensure we don't run reading the app state on the calling thread. ")
XCTAssertGreaterThanOrEqual(fixture.dispatchQueue.dispatchAsyncCalled, 3, "Expected at least 3 dispatchAsync calls (start, foreground, background) to ensure we don't run reading the app state on the calling thread.")
}

func testGoToForeground_WhenAppStateNil_NothingIsStored() {
Expand Down
Loading