Skip to content

Conversation

@philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 23, 2025

Previously, the test verified the number of logged messages, causing fragile failures if unrelated logs were added. Now it asserts the presence of the specific fatal log message, ensuring stability even when additional logs are introduced.

Test failed here: https://github.com/getsentry/sentry-cocoa/actions/runs/18740554352/job/53455824782?pr=6508

#skip-changelog

Closes #6511

Previously, the test verified the number of logged messages, causing
fragile failures if unrelated logs were added. Now it asserts the
presence of the specific fatal log message, ensuring stability even when
additional logs are introduced.
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.939%. Comparing base (fe83264) to head (1a770fd).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6510       +/-   ##
=============================================
- Coverage   86.996%   86.939%   -0.058%     
=============================================
  Files          452       451        -1     
  Lines        37691     37547      -144     
  Branches     17488     17388      -100     
=============================================
- Hits         32790     32643      -147     
+ Misses        4854      4628      -226     
- Partials        47       276      +229     

see 47 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe83264...1a770fd. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for pinning the assertion down to the actual message

@philipphofmann philipphofmann enabled auto-merge (squash) October 23, 2025 14:33
@philipphofmann philipphofmann merged commit 2c59847 into main Oct 24, 2025
170 of 179 checks passed
@philipphofmann philipphofmann deleted the test/fix-flaky-create-dir-if-not-exists branch October 24, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: Improve FileManager PathTooLong assert

2 participants