feat: Workspace filesystem cleanup #391
2 issues
xcodebuildmcp-snapshot-fixture-review: Found 2 issues (2 medium)
Medium
Discovered test total changed from 52 to 57 without corresponding item list update - `src/snapshot-tests/__fixtures__/json/device/test--failure.json:34`
The discovered.total field was updated from 52 to 57, but the visible items array in the surrounding context only shows a small subset and there's no indication that 5 new test items were added to the fixture. If the total count changed without a matching behavioral change in test discovery, this may indicate a fixture being patched to make tests pass rather than reflecting an intentional behavior change. Reviewers should verify that the new total of 57 corresponds to actual added test cases in the fixture's items array.
Also found at:
src/snapshot-tests/__fixtures__/mcp/simulator/test--failure.txt:10-24
New testCases entries omit the 'suite' field present on existing entries - `src/snapshot-tests/__fixtures__/json/simulator/test--failure.json:68-238`
The 34 newly added testCases objects (lines 68-238) only contain 'test', 'status', and 'durationMs' fields, while every pre-existing testCase entry in the same array includes a 'suite' field (e.g., 'CalculatorAppTests'). This indicates the JSON structured output envelope shape is no longer stable across entries within the same array, which violates the guardrail that JSON fixtures preserve stable structured output envelopes. Consumers parsing testCases will encounter inconsistent schemas within a single response.
Duration: 6m 42s · Tokens: 1.8M in / 3.1k out · Cost: $3.01 (+merge: $0.00)
Annotations
Check warning on line 34 in src/snapshot-tests/__fixtures__/json/device/test--failure.json
sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review
Discovered test total changed from 52 to 57 without corresponding item list update
The `discovered.total` field was updated from 52 to 57, but the visible `items` array in the surrounding context only shows a small subset and there's no indication that 5 new test items were added to the fixture. If the total count changed without a matching behavioral change in test discovery, this may indicate a fixture being patched to make tests pass rather than reflecting an intentional behavior change. Reviewers should verify that the new total of 57 corresponds to actual added test cases in the fixture's items array.
Check warning on line 24 in src/snapshot-tests/__fixtures__/mcp/simulator/test--failure.txt
sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review
[EEW-NJ7] Discovered test total changed from 52 to 57 without corresponding item list update (additional location)
The `discovered.total` field was updated from 52 to 57, but the visible `items` array in the surrounding context only shows a small subset and there's no indication that 5 new test items were added to the fixture. If the total count changed without a matching behavioral change in test discovery, this may indicate a fixture being patched to make tests pass rather than reflecting an intentional behavior change. Reviewers should verify that the new total of 57 corresponds to actual added test cases in the fixture's items array.
Check warning on line 238 in src/snapshot-tests/__fixtures__/json/simulator/test--failure.json
sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review
New testCases entries omit the 'suite' field present on existing entries
The 34 newly added testCases objects (lines 68-238) only contain 'test', 'status', and 'durationMs' fields, while every pre-existing testCase entry in the same array includes a 'suite' field (e.g., 'CalculatorAppTests'). This indicates the JSON structured output envelope shape is no longer stable across entries within the same array, which violates the guardrail that JSON fixtures preserve stable structured output envelopes. Consumers parsing testCases will encounter inconsistent schemas within a single response.