Skip to content

fix: Unref stopped simulator logging helpers

9631f13
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: Workspace filesystem cleanup #391

fix: Unref stopped simulator logging helpers
9631f13
Select commit
Loading
Failed to load commit list.
GitHub Actions / warden: xcodebuildmcp-snapshot-fixture-review completed May 5, 2026 in 6m 29s

1 issue

xcodebuildmcp-snapshot-fixture-review: Found 1 issue (1 medium)

Medium

discovered.total bumped from 52 to 57 without matching items list expansion - `src/snapshot-tests/__fixtures__/json/device/test--failure.json:34`

The hunk increases tests.discovered.total from 52 to 57, but the visible items list in the surrounding context shows no corresponding additions of five new test entries. If the underlying test count did not actually grow by five, this fixture change would be a snapshot-only patch unrelated to the workspace filesystem cleanup behavior change, which violates the guardrail that fixture updates must map to intentional behavior changes and stay aligned with structured output. Reviewers should confirm the items array elsewhere in the fixture grew by exactly 5 entries; otherwise this is a fixture patched only to make tests pass.


Duration: 6m 28s · Tokens: 1.8M in / 2.3k out · Cost: $10.94

Annotations

Check warning on line 34 in src/snapshot-tests/__fixtures__/json/device/test--failure.json

See this annotation in the file changed.

@github-actions github-actions / warden: xcodebuildmcp-snapshot-fixture-review

discovered.total bumped from 52 to 57 without matching items list expansion

The hunk increases `tests.discovered.total` from 52 to 57, but the visible items list in the surrounding context shows no corresponding additions of five new test entries. If the underlying test count did not actually grow by five, this fixture change would be a snapshot-only patch unrelated to the workspace filesystem cleanup behavior change, which violates the guardrail that fixture updates must map to intentional behavior changes and stay aligned with structured output. Reviewers should confirm the items array elsewhere in the fixture grew by exactly 5 entries; otherwise this is a fixture patched only to make tests pass.