feat: Workspace filesystem cleanup #391
2 issues
xcodebuildmcp-snapshot-fixture-review: Found 2 issues (2 medium)
Medium
Build Logs path not updated to workspace-scoped layout - `src/snapshot-tests/__fixtures__/cli/simulator/test--failure.txt:100`
The Derived Data path was updated to the new workspace-scoped layout (workspaces/XcodeBuildMCP-<HASH>/DerivedData/...), but the Build Logs path on the final line still points to the old top-level XcodeBuildMCP/logs/ directory. If the workspace cleanup refactor moved logs under the workspace-keyed path (as Derived Data was), this fixture is internally inconsistent and may indicate MCP/CLI/JSON fixture drift. If logs intentionally remain at the top level, ignore.
Test count and failure list change unrelated to workspace path refactor - `src/snapshot-tests/__fixtures__/mcp/simulator/test--failure.txt:9-35`
This fixture update mixes a workspace-scoped Derived Data path change (the stated intent of the PR) with a substantive change in observed test results: the discovered test count increases from 52 to 57 and failures grow from 2 to 4, adding new Swift Testing-style entries. The skill's guardrails require that fixture updates map to intentional behavior changes and that updates not be made solely to make tests pass. The PR description only mentions workspace-scoped path churn, so the additional test discovery/failure deltas need to be justified as an intentional behavior change or reverted; otherwise the fixture may be masking an unrelated regression or test-suite drift.
Duration: 2m 18s · Tokens: 1.7M in / 7.6k out · Cost: $4.09 (+extraction: $0.00, +merge: $0.00)
Annotations
Check warning on line 100 in src/snapshot-tests/__fixtures__/cli/simulator/test--failure.txt
sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review
Build Logs path not updated to workspace-scoped layout
The Derived Data path was updated to the new workspace-scoped layout (`workspaces/XcodeBuildMCP-<HASH>/DerivedData/...`), but the Build Logs path on the final line still points to the old top-level `XcodeBuildMCP/logs/` directory. If the workspace cleanup refactor moved logs under the workspace-keyed path (as Derived Data was), this fixture is internally inconsistent and may indicate MCP/CLI/JSON fixture drift. If logs intentionally remain at the top level, ignore.
Check warning on line 35 in src/snapshot-tests/__fixtures__/mcp/simulator/test--failure.txt
sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review
Test count and failure list change unrelated to workspace path refactor
This fixture update mixes a workspace-scoped Derived Data path change (the stated intent of the PR) with a substantive change in observed test results: the discovered test count increases from 52 to 57 and failures grow from 2 to 4, adding new Swift Testing-style entries. The skill's guardrails require that fixture updates map to intentional behavior changes and that updates not be made solely to make tests pass. The PR description only mentions workspace-scoped path churn, so the additional test discovery/failure deltas need to be justified as an intentional behavior change or reverted; otherwise the fixture may be masking an unrelated regression or test-suite drift.