Skip to content

feat: Workspace filesystem cleanup #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameroncooke merged 17 commits into from
May 5, 2026

Fix daemon registry ownership validation and remove unused function

829b538
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: Workspace filesystem cleanup #391

Fix daemon registry ownership validation and remove unused function
829b538
Select commit
Loading
Failed to load commit list.
GitHub Actions / warden: code-simplifier completed May 4, 2026 in 14m 19s

1 issue

code-simplifier: Found 1 issue (1 low)

Low

Nested ternary reduces clarity in shouldRecoverLockDir - `src/utils/fs-lock.ts:80-84`

The early-return branch uses a ternary expression wrapping an awaited call to construct the result object, which the skill explicitly discourages in favor of clear if/else chains. Replacing it with explicit if/else improves readability and matches the project's code-simplifier guidance. User-visible impact: maintainers must mentally parse the ternary plus object shorthand to understand control flow.

Also found at:

  • src/daemon.ts:152-171
  • src/utils/runtime-instance.ts:53-55

Duration: 14m 15s · Tokens: 627.0k in / 2.1k out · Cost: $1.12 (+merge: $0.00)

View more details on GitHub Actions