feat: Workspace filesystem cleanup #391
2 issues
xcodebuildmcp-snapshot-fixture-review: Found 2 issues (1 medium, 1 low)
Medium
New 'Running tests' progress lines unrelated to workspace cleanup added to fixture - `src/snapshot-tests/__fixtures__/cli/macos/test--success.txt:16-17`
The hunk adds two 'Running tests (N completed, ...)' lines to the fixture in addition to the workspace-scoped Derived Data path change. The PR scope is workspace filesystem cleanup, which justifies the path change, but the added progress output is not explained by the described behavior change. If these lines reflect volatile/runtime progress, they should be normalized in code rather than baked into the fixture; if they reflect an intentional output change, that change is outside the stated scope of this PR. This risks fixture updates being made primarily to make tests pass rather than reflecting an intentional, in-scope behavior change.
Also found at:
src/snapshot-tests/__fixtures__/mcp/device/test--failure.txt:11-18src/snapshot-tests/__fixtures__/mcp/simulator/test--failure.txt:9-34
Low
Build Logs path retains legacy non-workspace location - `src/snapshot-tests/__fixtures__/cli/simulator/test--failure.txt:100`
The Derived Data path was updated to the new workspace-scoped layout (workspaces/XcodeBuildMCP-<HASH>/DerivedData/...), but the Build Logs line at the bottom still points at <HOME>/Library/Developer/XcodeBuildMCP/logs/... rather than a workspace-scoped logs path. If the workspace cleanup change moves logs under the workspace directory (as the PR description suggests), the MCP, CLI, and JSON fixtures may be out of alignment, violating the 'MCP, CLI, and JSON fixture updates stay aligned' guardrail. If logs intentionally remain global, this is fine.
Duration: 5m 32s · Tokens: 1.5M in / 3.1k out · Cost: $2.58 (+merge: $0.00)
Annotations
Check warning on line 17 in src/snapshot-tests/__fixtures__/cli/macos/test--success.txt
sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review
New 'Running tests' progress lines unrelated to workspace cleanup added to fixture
The hunk adds two 'Running tests (N completed, ...)' lines to the fixture in addition to the workspace-scoped Derived Data path change. The PR scope is workspace filesystem cleanup, which justifies the path change, but the added progress output is not explained by the described behavior change. If these lines reflect volatile/runtime progress, they should be normalized in code rather than baked into the fixture; if they reflect an intentional output change, that change is outside the stated scope of this PR. This risks fixture updates being made primarily to make tests pass rather than reflecting an intentional, in-scope behavior change.
Check warning on line 18 in src/snapshot-tests/__fixtures__/mcp/device/test--failure.txt
sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review
[MX2-BS3] New 'Running tests' progress lines unrelated to workspace cleanup added to fixture (additional location)
The hunk adds two 'Running tests (N completed, ...)' lines to the fixture in addition to the workspace-scoped Derived Data path change. The PR scope is workspace filesystem cleanup, which justifies the path change, but the added progress output is not explained by the described behavior change. If these lines reflect volatile/runtime progress, they should be normalized in code rather than baked into the fixture; if they reflect an intentional output change, that change is outside the stated scope of this PR. This risks fixture updates being made primarily to make tests pass rather than reflecting an intentional, in-scope behavior change.
Check warning on line 34 in src/snapshot-tests/__fixtures__/mcp/simulator/test--failure.txt
sentry-warden / warden: xcodebuildmcp-snapshot-fixture-review
[MX2-BS3] New 'Running tests' progress lines unrelated to workspace cleanup added to fixture (additional location)
The hunk adds two 'Running tests (N completed, ...)' lines to the fixture in addition to the workspace-scoped Derived Data path change. The PR scope is workspace filesystem cleanup, which justifies the path change, but the added progress output is not explained by the described behavior change. If these lines reflect volatile/runtime progress, they should be normalized in code rather than baked into the fixture; if they reflect an intentional output change, that change is outside the stated scope of this PR. This risks fixture updates being made primarily to make tests pass rather than reflecting an intentional, in-scope behavior change.