Skip to content

Fix fallback workspace key derivation in forceStopDaemon

699fe46
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: Workspace filesystem cleanup #391

Fix fallback workspace key derivation in forceStopDaemon
699fe46
Select commit
Loading
Failed to load commit list.
GitHub Actions / warden: xcodebuildmcp-snapshot-fixture-review completed May 4, 2026 in 2m 31s

2 issues

xcodebuildmcp-snapshot-fixture-review: Found 2 issues (2 medium)

Medium

Volatile test progress lines added to fixture without normalization - `src/snapshot-tests/__fixtures__/cli/swift-package/test--failure.txt:8-14`

The fixture now includes seven 'Running tests (N completed, M failure, ...)' progress lines. These lines depend on test execution timing/ordering and are not normalized like other volatile values (timestamps, PIDs, hashes). Per the skill guardrails, volatile values should be normalized in code rather than baked into fixtures, otherwise the snapshot will be flaky across runs. The Derived Data path change is expected (workspace-scoped path), but these progress lines are a separate concern.

Test failure count jumps from 2 to 4 alongside path-only refactor - `src/snapshot-tests/__fixtures__/mcp/simulator/test--failure.txt:9-33`

This fixture update mixes two unrelated changes: the workspace-scoped Derived Data path rename, and a substantive change in test discovery/failure counts (52→57 discovered, 2→4 failures, with two new failing test entries). The PR description scopes fixture churn to 'new workspace-scoped paths', but new failing tests and discovered counts indicate a behavior change in the underlying test suite or runner output that is not explained. Per the skill guardrail 'Fixture updates map to intentional behavior changes' and 'Do not update fixtures only to make tests pass', the reviewer cannot verify whether these added failures are intentional or accidental snapshot drift.


Duration: 2m 27s · Tokens: 1.5M in / 2.2k out · Cost: $9.25 (+merge: $0.00)

Annotations

Check warning on line 14 in src/snapshot-tests/__fixtures__/cli/swift-package/test--failure.txt

See this annotation in the file changed.

@github-actions github-actions / warden: xcodebuildmcp-snapshot-fixture-review

Volatile test progress lines added to fixture without normalization

The fixture now includes seven 'Running tests (N completed, M failure, ...)' progress lines. These lines depend on test execution timing/ordering and are not normalized like other volatile values (timestamps, PIDs, hashes). Per the skill guardrails, volatile values should be normalized in code rather than baked into fixtures, otherwise the snapshot will be flaky across runs. The Derived Data path change is expected (workspace-scoped path), but these progress lines are a separate concern.

Check warning on line 33 in src/snapshot-tests/__fixtures__/mcp/simulator/test--failure.txt

See this annotation in the file changed.

@github-actions github-actions / warden: xcodebuildmcp-snapshot-fixture-review

Test failure count jumps from 2 to 4 alongside path-only refactor

This fixture update mixes two unrelated changes: the workspace-scoped Derived Data path rename, and a substantive change in test discovery/failure counts (52→57 discovered, 2→4 failures, with two new failing test entries). The PR description scopes fixture churn to 'new workspace-scoped paths', but new failing tests and discovered counts indicate a behavior change in the underlying test suite or runner output that is not explained. Per the skill guardrail 'Fixture updates map to intentional behavior changes' and 'Do not update fixtures only to make tests pass', the reviewer cannot verify whether these added failures are intentional or accidental snapshot drift.