-
Notifications
You must be signed in to change notification settings - Fork 6
chore: add top-level .editorconfig, copied from the ditto repository
#95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kristopherjohnson
wants to merge
5
commits into
main
Choose a base branch
from
kj/editorconfig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
74a49a7
chore: add top-level `.editorconfig`, copied from the `ditto` repository
kristopherjohnson a5aea64
Update .editorconfig
kristopherjohnson cd5b72c
Update .editorconfig
kristopherjohnson 18b62af
chore(cpp): remove unnecessary comment
kristopherjohnson 0f3916a
fix: revert accidental local AAR dependency in android-cpp build.grad…
kristopherjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,34 @@ | ||||||||
| # top-most EditorConfig file | ||||||||
| root = true | ||||||||
|
|
||||||||
| # Unix-style newlines with a newline ending every file | ||||||||
| [*] | ||||||||
| end_of_line = lf | ||||||||
| insert_final_newline = true | ||||||||
| trim_trailing_whitespace = true | ||||||||
|
|
||||||||
| [*.{cjs,js,json,ts}] | ||||||||
| indent_size = 2 | ||||||||
|
|
||||||||
| [*.sh] | ||||||||
| # like -i=4 | ||||||||
| indent_style = space | ||||||||
| indent_size = 4 | ||||||||
| switch_case_indent = false | ||||||||
|
|
||||||||
|
|
||||||||
| # Exclude files and directories by ensuring they are not matched by any section | ||||||||
| # Files like .cxx, gradlew*, and node_modules are not explicitly matched in this file. | ||||||||
|
|
||||||||
| # Exclude target directory | ||||||||
| [!target/**] | ||||||||
|
|
||||||||
| # Exclude .direnv directory | ||||||||
| [!.direnv/**] | ||||||||
|
|
||||||||
| # Exclude Pods directory | ||||||||
| [!**/Pods/**] | ||||||||
|
|
||||||||
| # Exclude node_modules directory | ||||||||
| [!**/node_modules/**] | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
|
||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think .editorconfig supports ignoring paths, these lines define empty rulesets applying to any path that does not match e.g.
target/**.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding
ignore = trueunder a[heading]will tell editors to ignore files under a matching path.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm seeing that
ignoreis not a valid EditorConfig property. Theignore = truesyntax is supported by shfmt, which is what we're using to lint and format shell scripts in the monorepo.One SO answer suggests setting all properties to
unsetto disable validation.