Skip to content

Conversation

@kristopherjohnson
Copy link
Collaborator

Adds an .editorconfig file to the Quickstart repo, which matches the configuration used in the ditto repo.

This will help maintain consistent formatting for everyone who contributes to this repo.

@kristopherjohnson kristopherjohnson self-assigned this Jul 24, 2025
Copilot AI review requested due to automatic review settings July 24, 2025 14:20
@kristopherjohnson kristopherjohnson requested a review from a team as a code owner July 24, 2025 14:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a top-level .editorconfig file to establish consistent code formatting standards across the repository. The configuration is copied from the ditto repository to maintain consistency between projects.

  • Adds universal formatting rules for line endings, trailing whitespace, and final newlines
  • Configures language-specific indentation for JavaScript/TypeScript (2 spaces) and shell scripts (4 spaces)
  • Sets up ignore patterns for generated directories and dependencies

.editorconfig Outdated
Comment on lines 25 to 39
[{.cxx,gradlew*,node_modules}]
ignore = true

[target/**]
ignore = true

[.direnv/**]
ignore = true

[**/Pods/**]
ignore = true

[**/node_modules/**]
ignore = true

Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ignore property is not a valid EditorConfig property. EditorConfig doesn't support an ignore directive.

Suggested change
[{.cxx,gradlew*,node_modules}]
ignore = true
[target/**]
ignore = true
[.direnv/**]
ignore = true
[**/Pods/**]
ignore = true
[**/node_modules/**]
ignore = true

Copilot uses AI. Check for mistakes.
.editorconfig Outdated
Comment on lines 25 to 39
[{.cxx,gradlew*,node_modules}]
ignore = true

[target/**]
ignore = true

[.direnv/**]
ignore = true

[**/Pods/**]
ignore = true

[**/node_modules/**]
ignore = true

Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ignore property is not a valid EditorConfig property. EditorConfig doesn't support an ignore directive.

Suggested change
[{.cxx,gradlew*,node_modules}]
ignore = true
[target/**]
ignore = true
[.direnv/**]
ignore = true
[**/Pods/**]
ignore = true
[**/node_modules/**]
ignore = true

Copilot uses AI. Check for mistakes.
.editorconfig Outdated
Comment on lines 25 to 39
[{.cxx,gradlew*,node_modules}]
ignore = true

[target/**]
ignore = true

[.direnv/**]
ignore = true

[**/Pods/**]
ignore = true

[**/node_modules/**]
ignore = true

Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ignore property is not a valid EditorConfig property. EditorConfig doesn't support an ignore directive.

Suggested change
[{.cxx,gradlew*,node_modules}]
ignore = true
[target/**]
ignore = true
[.direnv/**]
ignore = true
[**/Pods/**]
ignore = true
[**/node_modules/**]
ignore = true

Copilot uses AI. Check for mistakes.
.editorconfig Outdated
Comment on lines 25 to 39
[{.cxx,gradlew*,node_modules}]
ignore = true

[target/**]
ignore = true

[.direnv/**]
ignore = true

[**/Pods/**]
ignore = true

[**/node_modules/**]
ignore = true

Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ignore property is not a valid EditorConfig property. EditorConfig doesn't support an ignore directive.

Suggested change
[{.cxx,gradlew*,node_modules}]
ignore = true
[target/**]
ignore = true
[.direnv/**]
ignore = true
[**/Pods/**]
ignore = true
[**/node_modules/**]
ignore = true

Copilot uses AI. Check for mistakes.
…le.kts

Reverted the Ditto C++ SDK dependency from local AAR file back to the
published Maven artifact version 4.11.0.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link
Contributor

@pvditto pvditto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think the ignore section will do anything though.

Comment on lines +20 to +33
# Exclude files and directories by ensuring they are not matched by any section
# Files like .cxx, gradlew*, and node_modules are not explicitly matched in this file.

# Exclude target directory
[!target/**]

# Exclude .direnv directory
[!.direnv/**]

# Exclude Pods directory
[!**/Pods/**]

# Exclude node_modules directory
[!**/node_modules/**]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think .editorconfig supports ignoring paths, these lines define empty rulesets applying to any path that does not match e.g. target/**.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding ignore = true under a [heading] will tell editors to ignore files under a matching path.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm seeing that ignore is not a valid EditorConfig property. The ignore = true syntax is supported by shfmt, which is what we're using to lint and format shell scripts in the monorepo.

One SO answer suggests setting all properties to unset to disable validation.

[!**/Pods/**]

# Exclude node_modules directory
[!**/node_modules/**]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[!**/node_modules/**]
[**/node_modules/**]
ignore = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants