Add single-step leaf-level P-model function - #302
Merged
Conversation
Biomee code of run_biomee_f_bysite() had been refactored using a suite of build_x() functions with the LULUC merge. This commit applies the same logic to the output preparation for pmodel .
This prepares a refactoring with the aim to have similar matrix arguments as luluc biomee model.
Member
Author
|
This currently does NOT give the same result as
|
Member
Author
|
The differences between
|
fabern
marked this pull request as ready for review
July 21, 2025 12:14
Member
Author
|
This is now ready for review and merge.
|
No change, already previously array() gave back NA is not initialized. This is now just more explicit.
Simply by using compressed RDS in vignettes
Decreases pkg version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds function for single-step leaf-level simulations of the P-model (
run_pmodel_onestep_f_bysite).This is based on the former branch
simple_pmodel. This branch should be used instead of the former since it has been rebased at the end of the commit history after the luluc merge.