Consolidate likelihoods v2 - #306
Merged
Merged
Conversation
This was referenced Jul 28, 2025
Closed
This allos to use that information within cost function making them much more robust.
fabern
force-pushed
the
consolidate-likelihoods_v2
branch
from
July 28, 2025 16:46
af46d5b to
6977e09
Compare
by using pmodel instead of gsleuning
fabern
commented
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge #302 first.
This slightly modifies the calibration:
calibrate_sofun()now hands parameters as named vector to the cost functions.Changes are fully backward compatible with the previous cost functions provided in the package.
It is possible (but highly unlikely) that previous custom cost functions show changed behavior, since in R named vectors behave almost exactly like unnamed ones.
Please merge #302 first. #302 will create v.5.2.0. #306 here will create v5.2.1