Skip to content

fix(gstd): put non-ethexe error variants under #[cfg(...)] #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
liferooter wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(gstd): put non-ethexe error variants under #[cfg(...)] #5171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gstd/src/common/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ pub enum UsageError {
/// This error occurs when providing zero gas amount to system gas reserving
/// function (see
/// [`Config::set_system_reserve`](crate::Config::set_system_reserve)).
#[cfg(not(feature = "ethexe"))]
#[error("System reservation amount can not be zero in config")]
ZeroSystemReservationAmount,
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb it make sense to add explicit enum variants, but this type even does not implement Encode, Decode. so, it's just internal repr of error.

Suggested change
ZeroSystemReservationAmount,
ZeroSystemReservationAmount = ???,

/// This error occurs when providing zero duration to mutex lock function
Expand All @@ -190,6 +191,7 @@ pub enum UsageError {
/// This error occurs when handle_reply is called without (or with zero)
/// reply deposit
/// (see [`MessageFuture::handle_reply`](crate::msg::MessageFuture::handle_reply)).
#[cfg(not(feature = "ethexe"))]
#[error("Reply deposit can not be zero when setting reply hook")]
ZeroReplyDeposit,
}
Expand Down
Loading